Document legacy and clarify bestfit parameters for Imagick::resizeImage#5056
Open
lacatoire wants to merge 11 commits into
Open
Document legacy and clarify bestfit parameters for Imagick::resizeImage#5056lacatoire wants to merge 11 commits into
lacatoire wants to merge 11 commits into
Conversation
jordikroon
reviewed
Jan 5, 2026
Member
There was a problem hiding this comment.
According to the changelog file the legacy property has also been added to a few other methods. Would you be able to implement these as well?
To be exact, this is the changelog of Imagick 3.4.0.
Imagick::adaptiveResizeImage, Imagick::cropThumbnailImage Imagick::resizeImage,
Imagick::scaleImage, and Imagick::thumbnailImage have all had a rounding bug fixed.
An additional parameter has been added to each of them, 'bool $legacy'. If legacy
is true, the calculations are done with the small rounding bug that existed in
Imagick before 3.4.0. If false, the calculations should produce the same results as
ImageMagick CLI does.
jordikroon
reviewed
Jan 6, 2026
jordikroon
left a comment
jordikroon
left a comment
Member
There was a problem hiding this comment.
Thanks! Looks good to me. Unless someone objects.
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
jordikroon
reviewed
Apr 22, 2026
Co-authored-by: Jordi Kroon <jordi@jordikroon.nl>
Co-authored-by: Jordi Kroon <jordi@jordikroon.nl>
Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
lacatoire
force-pushed
the
imagick/resizeimage-legacy-doc
branch
from
1a4468f to
c1d141a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR clarifies two optional parameters of
Imagick::resizeImage()Fixes #4816