Fix ldap_count_entries() return value documentation#5218
Open
lacatoire wants to merge 2 commits into
Open
Conversation
lacatoire
commented
Apr 22, 2026
lacatoire
commented
Apr 22, 2026
Co-authored-by: Louis-Arnaud <la.catoire@gmail.com>
lacatoire
force-pushed
the
document_ldap_count_entries
branch
from
2367fa6 to
ae3a143
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manual stated that
ldap_count_entries()returns false on failure.According to the OpenLDAP documentation and the PHP implementation, the function returns
-1on error.This PR corrects the return value documentation.
Reference: https://www.openldap.org/software/man.cgi?query=ldap_count_entries ("If an error occurs in ldap_count_entries(), -1 is returned, and ld_errno is set appropriately.")
Fixes #4683