Time\Duration by TimWolla · Pull Request #23073 · php/php-src

TimWolla · 2026-08-05T16:02:14Z

RFC: https://wiki.php.net/rfc/duration_class

derickr · 2026-08-05T16:18:40Z


 PHP_NEW_EXTENSION([date],
-  [php_date.c],
+  [php_date.c php_date_time.c php_date_time_duration.c],


I was hoping to get rid of the php_date prefix for all of the new stuff. We don't really need it, and it's inconsistent with all other extensions (something I got wrong in 2004). My intention was to move it all to just the class name (with namespace), such as:

date_time_immutable.c (For DateTimeImmutable)

time_duration.c (For Time/Duration)

It also helps auto-complete in the file browser opening files.

I've renamed php_date_time_duration.c to just time_duration.c and php_date_time.[ch] to php_time.[ch].

Just time.[ch] didn't work, because I assume something is erroneously including the system-wise time.h header with "" instead of <> or something. At least I got weird compiler errors I didn't want to investigate.

derickr · 2026-08-05T16:22:26Z

+
+static void throw_out_of_range_exception(void)
+{
+	zend_throw_exception(php_date_ce_time_timeexception, "The maximum representable range is 9_223_372_035 seconds (roughly 292 years)", 0);


There is the timelib_get_error_message() function that returns a string for each of the TIMELIB_ERROR codes. We can tweak these message, in case you don't think they're good enough for PHP.

I needed a custom implementation anyway for 32-bit PHP and to handle the overflows in the fromMinutes() and fromHours() constructors, so I would leave this as a special case.

arnaud-lb · 2026-08-05T16:32:37Z

+	object_init_ex(return_value, php_date_ce_time_duration);
+
+	php_date_time_duration *original = Z_DATE_TIME_DURATION_P(ZEND_THIS);
+	php_date_time_duration *additional = php_date_time_duration_from_obj(duration);


Suggested change

php_date_time_duration *additional = php_date_time_duration_from_obj(duration);

php_date_time_duration *addend = php_date_time_duration_from_obj(duration);

I was (re)using the timelib naming here, which has:

int timelib_duration_add_static( timelib_duration *new_duration, const timelib_duration *original, const timelib_duration *additional )

otherwise I also get a useless parameter name hint in VS Code:

arnaud-lb · 2026-08-05T16:34:45Z

+
+	php_date_time_duration *original = Z_DATE_TIME_DURATION_P(ZEND_THIS);
+	php_date_time_duration *additional = php_date_time_duration_from_obj(duration);
+	php_date_time_duration *new = Z_DATE_TIME_DURATION_P(return_value);


When either original or additional has recount==1, it may be possible to reuse it?

arnaud-lb · 2026-08-05T16:38:41Z

+ZEND_STATIC_ASSERT(MICROS_IN_NANOS * MICROS_IN_SEC == NANOS_IN_SEC, "");
+ZEND_STATIC_ASSERT(MILLIS_IN_NANOS * MILLIS_IN_SEC == NANOS_IN_SEC, "");
+
+static void sync_properties(php_date_time_duration *object)


Could we avoid this with hooks?

Before implementing this I had a quick chat with @iluuu1994 about this:

The class is specified to be readonly in the RFC and this needs to be specified in the stub to be visible to Reflection.

Hooks are semantically not legal on readonly properties. Marking the property as @virtual in the stub would be visible to reflection.

Also marking a property as @virtual would require me to manually implement read_property(), get_properties(), write_property(), and get_property_ptr_ptr() to obtain the correct behavior.

Since there is no such thing as a “internal only hook” for a property as far as I’m aware and given the upcoming freeze, I opted to materialize this into real properties for the initial version. This can (and probably should) be optimized with PHP 8.7.

Following php#23063.

RFC: https://wiki.php.net/rfc/duration_class

…om*()` This is useful for patterns like the following: for (;;) { $watchers = $poll->wait(Time\Duration::fromSeconds(1)); // … } which is repeatedly creating identical duration objects for every loop iteration.

github-actions Bot added Category: Build System Extension: date ABI break labels Aug 5, 2026

TimWolla force-pushed the time-duration branch from d6eda3e to 51e484b Compare August 5, 2026 16:04

derickr reviewed Aug 5, 2026

View reviewed changes

arnaud-lb reviewed Aug 5, 2026

View reviewed changes

TimWolla force-pushed the time-duration branch 8 times, most recently from ebb8107 to 5f203d8 Compare August 5, 2026 20:09

github-actions Bot added the Extension: standard label Aug 5, 2026

TimWolla added the RFC label Aug 5, 2026

TimWolla mentioned this pull request Aug 5, 2026

Add Polyfill for Time\Duration class symfony/polyfill#642

Open

TimWolla force-pushed the time-duration branch from 5f203d8 to 2df3006 Compare August 5, 2026 20:15

TimWolla requested review from arnaud-lb and derickr August 5, 2026 20:16

TimWolla force-pushed the time-duration branch 2 times, most recently from 89e45ab to 6390166 Compare August 5, 2026 20:43

TimWolla commented Aug 5, 2026

View reviewed changes

Comment thread ext/date/tests/time/duration/methods/add.phpt Outdated

Comment thread ext/date/tests/time/duration/methods/div.phpt Outdated

Comment thread ext/date/tests/time/duration/methods/mul.phpt Outdated

TimWolla commented Aug 5, 2026

View reviewed changes

Comment thread ext/date/php_time.c

Comment thread ext/date/php_time.c Outdated

TimWolla commented Aug 5, 2026

View reviewed changes

Comment thread ext/date/php_time.h Outdated

Comment thread ext/date/php_time.h Outdated

TimWolla force-pushed the time-duration branch 2 times, most recently from 074da03 to 1f0ff1f Compare August 6, 2026 07:38

TimWolla added 2 commits August 6, 2026 09:45

date: Add new timelib/duration.c source file to autoconf

2ca6690

Following php#23063.

timelib: Fix overflow in timelib_duration_div_static()

d9bb381

TimWolla force-pushed the time-duration branch from 1f0ff1f to 9e932e2 Compare August 6, 2026 07:45

TimWolla mentioned this pull request Aug 6, 2026

date: Add new timelib/duration.c source file to autoconf #23077

Open

TimWolla force-pushed the time-duration branch from 9e932e2 to 95eee76 Compare August 6, 2026 07:57

TimWolla and others added 3 commits August 6, 2026 10:23

date: Add Time\Duration

4a781c0

RFC: https://wiki.php.net/rfc/duration_class

standard: Take Time\Duration in Io\Poll\Context::wait()

d6e4043

RFC: https://wiki.php.net/rfc/duration_class

date: Cache the most recently Time\Duration object created with `fr…

a2a58e7

…om*()` This is useful for patterns like the following: for (;;) { $watchers = $poll->wait(Time\Duration::fromSeconds(1)); // … } which is repeatedly creating identical duration objects for every loop iteration.

TimWolla force-pushed the time-duration branch from 95eee76 to a2a58e7 Compare August 6, 2026 08:23

	php_date_time_duration *additional = php_date_time_duration_from_obj(duration);
	php_date_time_duration *addend = php_date_time_duration_from_obj(duration);

Uh oh!

Conversation

TimWolla commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

TimWolla commented Aug 5, 2026 •

edited

Loading