Updates and Fixes#314
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the sandbox customisation lifecycle (extensions/styles) by adding safer unmount flows that clean phpBB state first, ensuring predictable ordering in mounted lists, and enhancing the dashboard UI to better display mounted items.
Changes:
- Introduces a
CustomisationManagerInterfaceplus a newCustomisationUnmountService, and updates CLI/Web unmount flows to uninstall/purge in phpBB before removing mounts. - Ensures extension/style
list()results are sorted by name (case-insensitive with deterministic tie-break). - Updates the dashboard UI to show mounted counts, collapse “extra” mounted items behind a toggle, and adds small-button styling; improves
SourceProviderfloating-source publishing to support refreshingdev-master.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Unit/StyleManagerTest.php | Adds coverage for sorted style listing and bind remount preserving the mount target. |
| tests/Unit/SourceProviderTest.php | Adds coverage for refreshing dev-master sources and advancing floating stable releases. |
| tests/Unit/ExtensionManagerTest.php | Adds coverage for sorted extension listing and bind remount preserving the mount target. |
| tests/Unit/CustomisationUnmountServiceTest.php | New unit tests validating uninstall-before-unmount behavior and failure preserving mounts. |
| tests/Unit/CustomisationMountServiceTest.php | Updates test manager to implement the new customisation manager interface. |
| tests/Unit/BoardRunnerTest.php | Adds coverage for new BoardRunner uninstall behaviors (extension disable/purge, style cleanup script). |
| tests/Integration/WebApplicationTest.php | Updates integration assertions for mounted list UI (counts, toggle behavior, container query CSS). |
| src/QuickInstall/Sandbox/Web/templates/dashboard.php | UI: mounted counts, collapsible mounted lists, and smaller action buttons. |
| src/QuickInstall/Sandbox/Web/Application.php | Routes unmount actions through CustomisationUnmountService; tightens mount manager typing. |
| src/QuickInstall/Sandbox/StyleUninstallerWriter.php | New generator for a phpBB-bootstrapped style uninstall script. |
| src/QuickInstall/Sandbox/StyleManager.php | Implements interface, preserves bind remount targets, and sorts list() output. |
| src/QuickInstall/Sandbox/SourceProvider.php | Adds publishSource() to safely replace/refresh floating sources (notably dev-master). |
| src/QuickInstall/Sandbox/ExtensionManager.php | Implements interface and sorts list() output consistently. |
| src/QuickInstall/Sandbox/CustomisationUnmountService.php | New service to safely uninstall (if installed) then unmount + refresh + cleanup. |
| src/QuickInstall/Sandbox/CustomisationMountService.php | Updates API to accept CustomisationManagerInterface. |
| src/QuickInstall/Sandbox/CustomisationManagerInterface.php | New shared contract for extension/style managers. |
| src/QuickInstall/Sandbox/bootstrap.php | Registers new sandbox classes in bootstrap. |
| src/QuickInstall/Sandbox/BoardRunner.php | Adds uninstallExtension() and uninstallStyle() operations used by unmount service. |
| src/QuickInstall/Sandbox/Application.php | CLI unmount commands now use CustomisationUnmountService; updates help text and typing. |
| README.md | Copy-edit and credit updates. |
| public/assets/sandbox-ui.js | Adds mounted list toggle binding. |
| public/assets/sandbox-ui.css | Adds small button styling, mounted list/count styling, and container-query layout tweaks. |
| docs/sandbox-cli.md | Minor wording adjustments. |
| .github/CONTRIBUTING.md | Formatting and command instruction cleanup/clarification. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.