Fix fatal error when path has array value in ignoreErrors#5183
Merged
VincentLanglet merged 1 commit intophpstan:2.1.xfrom Mar 19, 2026
Merged
Fix fatal error when path has array value in ignoreErrors#5183VincentLanglet merged 1 commit intophpstan:2.1.xfrom
path has array value in ignoreErrors#5183VincentLanglet merged 1 commit intophpstan:2.1.xfrom
Conversation
Contributor
|
why is this parameter not validated against the schema? |
Contributor
Author
|
The |
VincentLanglet
approved these changes
Mar 12, 2026
Contributor
|
@ondrejmirtes you might want to give a word about the error wording ? |
staabm
approved these changes
Mar 19, 2026
… ignoreErrors When a user accidentally writes `path:` with an array value (intending `paths:`), ValidateIgnoredErrorsExtension crashes with a TypeError because FileExcluder::isAbsolutePath() receives an array instead of a string. The schema validation that would catch this runs after the DI extension, so it never gets a chance to report the misconfiguration. Added type checks for `path` (must be string) and `paths` (must be array) with helpful error messages suggesting the correct key name.
staabm
force-pushed
the
fix-14231-path-type-validation
branch
from
ce331a9 to
29ee169
Compare
Contributor
|
Let's merge this, ondrej can still change the wording later ; it won't be a BC break. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#14231