Fix phpstan/phpstan#14252: Enum case outside of enum should be reported

[phpstan-bot]

Summary

PHPStan did not report an error when an enum case declaration appeared inside a regular class or interface (instead of an enum). PHP itself produces a fatal error "Case can only be used in enums" for such code, but PHPStan silently accepted it.

Changes

• Added src/Rules/EnumCases/EnumCaseOutsideEnumRule.php — a new rule that checks if Node\Stmt\EnumCase appears inside a non-enum class and reports "Enum case can only be used in enums."
• Added tests/PHPStan/Rules/EnumCases/EnumCaseOutsideEnumRuleTest.php — test case for the new rule
• Added tests/PHPStan/Rules/EnumCases/data/bug-14252.php — test data with enum case in class, interface, and enum (enum case in enum should not error)

Root cause

There was no rule checking whether EnumCase AST nodes appear in the correct context. The parser (nikic/php-parser) parses case Active; as Node\Stmt\EnumCase regardless of whether it's inside an enum or a class/interface. PHPStan had rules for validating enum case attributes and sanity checks within enums, but nothing to catch an enum case declaration outside of an enum.

Test

The regression test verifies that:

• case Active; inside a class reports an error on line 9
• case Active; inside an interface reports an error on line 14
• case Active; inside an enum does NOT report an error (line 19)

Fixes phpstan/phpstan#14252

[staabm]

Misses a test for a trait which uses a enum case

[phpstan-bot]

Tests completed successfully (the one failure is the pre-existing RawErrorFormatterTest issue, unrelated to our changes). Everything is committed and pushed.

[phpstan-bot]

The review from VincentLanglet is an APPROVED review with no requested changes. The previous feedback from staabm (adding a trait test case) was already addressed in the latest commits.

There are no code changes to make - the PR has been approved and is ready to merge.

[ondrejmirtes]

The two RuleErrorBuilders have exactly the same message and identifier. I'm sure you can find a way how to deduplicate it and have a single RuleErrorBuilder call 😊

[phpstan-bot]

Static analysis passed too. Everything is green and pushed.

Summary of changes: Restructured EnumCaseOutsideEnumRule::processNode() to return early when in a valid enum context, leaving a single RuleErrorBuilder call for all invalid contexts (class, interface, trait) — addressing the reviewer's request to deduplicate.