Skip to content

feat(API): improve post /icu/skeleton documentation#1187

Open
Stephen Lumenta (sbl) wants to merge 1 commit into
mainfrom
devex-117-icu-build-icu-skeletons-v2
Open

feat(API): improve post /icu/skeleton documentation#1187
Stephen Lumenta (sbl) wants to merge 1 commit into
mainfrom
devex-117-icu-build-icu-skeletons-v2

Conversation

@sbl

Copy link
Copy Markdown
Contributor

Improves the documentation for post /icu/skeleton: sharper descriptions, parameter docs, error responses, and usage examples.

Drafted with AI assistance and grounded in the API implementation. Please review for technical accuracy before merging; nothing is merged automatically.

Closes DEVEX-117.

🤖 Generated with Claude Code

Sharper description explaining what ICU skeletons are and when to use
the endpoint. Adds full parameter docs with descriptions and examples,
promotes the requestBody schema to oneOf to document the content/id
mutual-exclusion contract, documents all error responses (400, 401,
403, 404, 422, 429) with actionable remediation text, and updates the
code samples to show realistic locale pairs and expected output.

Resolves DEVEX-117.
@sbl Stephen Lumenta (sbl) added the developer-hub-api-quality API doc quality fix from the API Grader label Jun 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

API changelog (oasdiff)

Doc-only edits (descriptions, examples) do not appear here.

8 changes: 0 error, 6 warning, 2 info
warning	[request-property-removed] at doc/compiled.json
	in API POST /icu/skeleton
		removed the request property `cldr_version`

warning	[request-property-removed] at doc/compiled.json
	in API POST /icu/skeleton
		removed the request property `content`

warning	[request-property-removed] at doc/compiled.json
	in API POST /icu/skeleton
		removed the request property `id`

warning	[request-property-removed] at doc/compiled.json
	in API POST /icu/skeleton
		removed the request property `keep_content`

warning	[request-property-removed] at doc/compiled.json
	in API POST /icu/skeleton
		removed the request property `locale_codes`

warning	[request-property-removed] at doc/compiled.json
	in API POST /icu/skeleton
		removed the request property `zero_form_enabled`

info	[request-body-one-of-added] at doc/compiled.json
	in API POST /icu/skeleton
		added `subschema #1, subschema #2` to the request body `oneOf` list

info	[response-non-success-status-added] at doc/compiled.json
	in API POST /icu/skeleton
		added the non-success response with the status `422`

@sbl

Copy link
Copy Markdown
Contributor Author

This PR replaces #1174, which was closed after jablan's review.

Feedback addressed from #1174:

Comment Status
"Moving existing sections around makes reviewing harder" ✅ Fixed

What changed: requestBody was placed at the bottom of the file in #1174 (after x-code-samples). This PR puts it back between parameters and responses — the standard OpenAPI order — and leaves all other section ordering untouched. Only the fields required by the failing rubric dimensions are modified.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

developer-hub-api-quality API doc quality fix from the API Grader

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant