fix(webhook): wire HMAC signing secret through daemon CLI flags (PILOT-90) - #439
Merged
Conversation
…T-90) The webhook.Client already supported WithSecret and X-Pilot-Signature-256 header output since PR #3 (merged). However, the daemon's main.go never added the --webhook-secret flag or threaded it to webhook.WithSecret(), so the signing capability was inaccessible from the running daemon. This 2-line change adds: - --webhook-secret flag (env: PILOT_WEBHOOK_SECRET) - webhook.WithSecret(*webhookSecret) wiring in NewService call Backward compatible: empty secret = no signature header (existing behavior). Closes PILOT-90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Wire webhook HMAC signing secret through daemon CLI flags
The webhook library already supports
WithSecretandX-Pilot-Signature-256header output — this was implemented and merged in pilot-protocol/webhook#3. However, the daemon'smain.gonever added the--webhook-secretflag or threaded it through towebhook.WithSecret(), so the signing capability was inaccessible from the running daemon.What changed
--webhook-secretflag (env fallback:PILOT_WEBHOOK_SECRET) tocmd/daemon/main.gowebhook.WithSecret(*webhookSecret)in theNewServicecallVerification
go build ./cmd/daemon/...✅go vet ./cmd/daemon/...✅Closes PILOT-90