Add PR Guardrails trigger workflow - #148
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Verdict: Needs changes. Adds the repository trigger for centralized PR guardrails, but the CI completion trigger is ineffective and secret handling is unsafe.
Changes:
- Adds PR and check-suite guardrail triggers.
- Calls the centralized reusable guardrail workflow.
- Serializes guardrail runs per PR.
Review contract:
- Claim: Enable linked-issue, membership-bypass, and CI guardrails.
- Root cause: Not fully addressed;
check_suitecannot observe GitHub Actions CI completion (pr-guardrails.yml:11-12). - Call sites/boundary: Central workflow also requires event-handling changes.
- Compatibility: No public API impact.
- Testing: The workflow is unexercised.
- Docs: Inline documentation is sufficient.
- Risks: Mutable
@mainreceives inherited repository secrets (pr-guardrails.yml:26-27).
Comment on lines
+11
to
+12
| check_suite: | ||
| types: [completed] |
Comment on lines
+26
to
+27
| uses: pimcore/workflows-collection-public/.github/workflows/parent-pr-guardrails.yml@main | ||
| secrets: inherit |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts the org-wide PR guardrails (linked-issue requirement + Dev-Team membership bypass + CI gate) per pimcore/DevOps-Tasks#4.
Thin, generic trigger identical to the template in payment-provider-payu — it calls
parent-pr-guardrails.yml@mainwithsecrets: inherit. The three guardrail tokens are org-level secrets with all-repository access, so no per-repo wiring is needed.Note: the guardrail activates for PRs opened after this merges (
pull_request_targetruns the base-branch workflow definition), so this PR does not exercise it.