🔄 synced file(s) with pimcore/workflows-collection-public - #149
Merged
berfinyuksel merged 1 commit intoJul 24, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Verdict: Needs changes.
Synchronizes expanded backward-compatibility review guidance from the upstream workflow collection.
Changes:
- Enumerates common public API compatibility breaks.
- Adds deprecation guidance for changed defaults.
- Requires security and bug fixes to preserve shared defaults.
Review Contract
- Claim/root cause: The upstream policy is synchronized at
.github/skills/code-review/SKILL.md:25-32. - Coverage/boundary: No runtime call sites or APIs change; policy corrections belong upstream before resynchronization.
- Tests/docs: Documentation-only change; no regression test or changelog is needed.
- Risk:
.github/skills/code-review/SKILL.md:32mandates call-site-only remediation even when an unsafe shared default affects external consumers, conflicting with lines 20-24. This requires correction.
| parameter type, or reduced visibility, on a symbol that is not `@internal`. Require an | ||
| appropriate deprecation path instead of the break. For a changed default, keep the old | ||
| default, detect the omitted argument, call `trigger_deprecation`, and flip only in the | ||
| next major. "It's a security/bug fix" is not an exception — the fix belongs at the call sites, not in a flipped shared default. |
pimcore-deployments
marked this pull request as draft
July 24, 2026 09:45
Contributor
Author
|
🚫 Issue-link guardrail failed — this PR has been converted to draft. Every PR must reference a tracking issue in
Add the link with a keyword in the PR description (not in a comment): https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests When fixed, press Ready for review to re-run the checks. |
pimcore-deployments
force-pushed
the
repo-sync/workflows-collection-public/default
branch
from
July 24, 2026 11:45
2e61fbf to
216eed6
Compare
|
berfinyuksel
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
synced local file(s) with pimcore/workflows-collection-public.
This PR was created automatically by the repo-file-sync-action workflow run #30090550106