test(codegen): assert pine_* helper emission for time builtins (KI-35)#43
Merged
Merged
Conversation
PR #42 routed hour()/minute()/dayofweek()/... through the engine's cached pine_<field>() helpers instead of an inline setenv+tzset+localtime_r lambda. These emission tests still asserted the old inline internals (localtime_r, gmtime_r, normalize_timezone_for_posix, tm_buf.tm_*), so they broke. Update them to assert the new pine_<field>(...) call emission — the tz literal / syminfo_.timezone is still present (auditable) as the call argument, while the tm-field extraction + Pine offsets now live inside the engine helper. Test-only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the CI (Test) failure introduced by #42. The time-builtin emission tests asserted the old inline-lambda internals (
localtime_r/gmtime_r/normalize_timezone_for_posix/tm_buf.tm_*) that #42 removed by routing through the enginepine_<field>()helpers. Updated to assert the newpine_<field>(...)call emission; the tz literal /syminfo_.timezoneis still present (auditable) as the argument. Test-only; pytest green locally.🤖 Generated with Claude Code