Isolate nested UDF state by call path#52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
fixnanstate as clone-requiring state.Root cause
An outer function could be cloned per call site while a nested helper whose only state was
math.sumorfixnanremained shared. Multiple consumers then advanced one rolling state instance each bar. In Todrock, bothf_tqivariants calledf_er_cs0, phase-skewing the 20-bar efficiency-ratio denominator.Impact
Todrock moves from moderate to strong: canonical match 92.9% → 99.5%, with 421/452 raw TV trades matched, exact prices, and entry/exit p90 at zero. The full campaign gate moves exactly one strategy up and none down, raising excellent+strong from 353 to 354/400.
Validation
Reviewed diff SHA-256:
81e797f069ce100737a359214a335f7cc6a76adff303350a2239fb3829315a31