Gate role-changing fixed reversals by free margin#86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
Two market entries can be queued for the same next tick. The second may be same-direction when created, then become a reversal after the first fills. The engine admitted that stale-role order without rechecking the larger reversal transaction, producing an extra flip.
Impact
The validated GB2 strategy moves from moderate to strong: engine trades 3153 → 2685, with all 2617 TV trades matched and count delta reduced 536 → 68. The full campaign sweep had one upward tier move and no downward moves.
Validation
Production diff SHA-256:
c204dddb8a9126c8bed503eb2a425d1e7051a1056a9bc37f69bdbb5810330302