Skip to content

cdc: add table routing feature #23211

Open
qiancai wants to merge 11 commits into
pingcap:masterfrom
qiancai:cdc-table-route-feature-21723
Open

cdc: add table routing feature #23211
qiancai wants to merge 11 commits into
pingcap:masterfrom
qiancai:cdc-table-route-feature-21723

Conversation

@qiancai

@qiancai qiancai commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3. labels Jul 7, 2026
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 7, 2026
Synced from: pingcap/docs-cn#21723
Target PR: pingcap#23211
AI Provider: azure

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Auto-sync completed successfully

Source PR: pingcap/docs-cn#21723
Target PR: #23211

English documentation has been updated based on Chinese documentation changes.

@ti-chi-bot ti-chi-bot Bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 7, 2026
Comment thread ticdc/ticdc-table-routing.md Outdated
@qiancai

qiancai commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new documentation page for TiCDC Table Routing, updates the table of contents, and revises the changefeed configuration documentation to reflect this new feature. The reviewer's feedback is highly constructive, focusing on style guide compliance such as converting passive voice to active voice, replacing "synchronize" with "replicate", correcting localized Chinese anchor links, and ensuring consistent casing for technical terms.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread ticdc/ticdc-table-routing.md Outdated
Comment thread ticdc/ticdc-table-routing.md Outdated
Comment thread ticdc/ticdc-table-routing.md Outdated
Comment thread ticdc/ticdc-table-routing.md Outdated
Comment thread ticdc/ticdc-table-routing.md Outdated
Comment thread ticdc/ticdc-table-routing.md Outdated
Comment thread ticdc/ticdc-table-routing.md Outdated
Comment thread ticdc/ticdc-table-routing.md Outdated
Comment thread ticdc/ticdc-table-routing.md Outdated
Comment thread ticdc/ticdc-table-routing.md Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Comment thread ticdc/ticdc-table-routing.md Outdated
Comment thread ticdc/ticdc-table-routing.md Outdated
@ti-chi-bot

ti-chi-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

@3AceShowHand: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment thread ticdc/ticdc-table-routing.md Outdated
@qiancai qiancai self-assigned this Jul 7, 2026
Comment thread ticdc/ticdc-table-routing.md Outdated
Comment thread ticdc/ticdc-table-routing.md Outdated
@ti-chi-bot

ti-chi-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment thread ticdc/ticdc-table-routing.md Outdated
Comment thread ticdc/ticdc-changefeed-config.md Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v9.0-beta.3 This PR/issue applies to TiDB v9.0-beta.3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants