i18n(ja): strip stray Japanese quotes wrapping bold UI labels - #23576
Open
yahonda wants to merge 1 commit into
Open
i18n(ja): strip stray Japanese quotes wrapping bold UI labels#23576yahonda wants to merge 1 commit into
yahonda wants to merge 1 commit into
Conversation
The English source never wraps a bold UI-label span (e.g. Click **Connect**) in quotes, but the ja translation had accumulated 「」 around many such spans (e.g. **「接続」**), across single-word button labels, symbols (**「+」**, **「...」**), and longer descriptive labels (**「クラウドストレージからデータをインポート」**). Verified this pattern holds against EN for a representative sample across short and long labels before doing a mechanical, corpus-wide strip: **「X」** -> **X**, applied only where the quote marks sit immediately inside the bold delimiters (1,577 occurrences across 233 files). This supersedes the narrower carve-outs used in PR pingcap#23551/pingcap#23552, which kept a handful of terms quoted for in-file convention (接続 タイプ, スキーマロード, 接続方法, 組織設定, etc.) - per the standing policy, in-file consistency is not a reason to keep quoting a term EN never quotes. Verified per-file: line count, ** count, [ count, and ] count are all unchanged (0 anomalies across all 233 changed files) - only the 「」 characters were removed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ti-chi-bot
Bot
added
the
area/develop
|
Important Review skippedToo many files! This PR contains 233 files, which is 83 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (233)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ti-chi-bot
Bot
added
the
missing-translation-status
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ti-chi-bot
Bot
added
the
size/XXL
qiancai
added
translation/no-need
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
The English source never wraps a bold UI-label span (e.g.
Click **Connect**) in quotes, but the ja translation had accumulated「」around many such spans (e.g.**「接続」**), across single-word button labels, symbols (**「+」**,**「...」**), and longer descriptive labels (**「クラウドストレージからデータをインポート」**).Verified this pattern holds against EN for a representative sample across short and long labels before doing a mechanical, corpus-wide strip:
**「X」**->**X**, applied only where the quote marks sit immediately inside the bold delimiters. 1,577 occurrences across 233 files.This supersedes the narrower carve-outs used in PR #23551/#23552, which kept a handful of terms quoted for in-file convention (接続タイプ, スキーマロード, 接続方法, 組織設定, etc.) — per the standing policy, in-file consistency is not a reason to keep quoting a term EN never quotes.
Verified per-file: line count,
**count,[count, and]count are all unchanged (0 anomalies across all 233 changed files) — only the「」characters were removed.Known large overlap with other open PRs — this touches many of the same files as #23554 (122 files), #23559 (94 files), #23552 (75 files), #23562 (48 files), #23564 (7 files), #23538 (2 files). Expect to rebase this PR as those merge.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?