docs: unify "standardized" to "normalized" for SQL statements in sql-plan-management.md - #23581
Conversation
|
test seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe binding documentation now uses “normalized SQL statement” terminology for binding replacement and baseline evolution. ChangesSQL Plan Management documentation
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This localized documentation-only terminology update is merge-ready after normal checks and review, with no actionable merge-blocking risk remaining. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…plan-management.md This file defines the term `Normalization` and uses "normalizes" / "normalized" consistently elsewhere (e.g. "The TiDB optimizer normalizes bound SQL statements", "Digest of a normalized SQL statement" in the sql_digest table), but 3 sentences used the inconsistent synonym "standardized" for the same concept. Unified to "normalized" to match the file's own defined terminology.
fdccc76 to
a920ee1
Compare
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What is changed, added or deleted? (Required)
sql-plan-management.mddefines the term`Normalization`and uses "normalizes" / "normalized" consistently elsewhere in the same file (e.g. "The TiDB optimizer normalizes bound SQL statements", and thesql_digesttable row "Digest of a normalized SQL statement"), but 3 sentences used the inconsistent synonym "standardized" for the exact same concept (a SQL statement that has gone through Normalization). This was found while investigating a related Japanese translation inconsistency that traced back to this English source ambiguity.Unified all 3 occurrences to "normalized" to match the file's own defined terminology.
Origin of the "standardized" wording (found via
git blame):Both trace back to the same Chinese source term "标准化" (literally "standardize"), which this file's own English translation deliberately renders as "Normalization" as its formal defined term elsewhere - the "standardized" instances are just places where that established EN term wasn't applied consistently.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
AI agent involvement
Do your changes match any of the following descriptions?