fix(codex): wait for plugin sync before loading skills#4461
Draft
THEKINGJEZE wants to merge 1 commit into
Draft
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Codex app-server materialises enabled remote plugins asynchronously after initialisation. T3 read
skills/listimmediately and cached that incomplete snapshot for both the skill picker and new threads. Remote-plugin materialisation does not emitskills/changed, so affected sessions remained incomplete.plugin/installedprovides a readiness barrier. After it resolves,skills/listwithforceReload: truereturns the complete installed skill set.Verification
$pickersuperpowers:systematic-debuggingsuperpowers:test-driven-developmentsuperpowers:writing-planssuperpowers:verification-before-completionThe
/picker remains the built-in command picker; skills are intentionally discovered through$.Note
Wait for plugin sync before loading skills in Codex provider and session runtime
refreshCodexSkillsAfterPluginSyncin CodexProvider.ts, which first awaitsplugin/installedand then requestsskills/listwithforceReload=true.probeCodexAppServerProviderto use this utility instead of callingskills/listdirectly.openCodexThreadin CodexSessionRuntime.ts to run the plugin sync + skills reload step before starting or resuming a thread.plugin/installedthenskills/list) to both the probe and thread-open paths.Macroscope summarized 6364b63.