Skip to content

Fix Windows thread edge background#4493

Draft
SunkenInTime wants to merge 2 commits into
pingdotgg:mainfrom
SunkenInTime:agent/windows-thread-right-edge-background
Draft

Fix Windows thread edge background#4493
SunkenInTime wants to merge 2 commits into
pingdotgg:mainfrom
SunkenInTime:agent/windows-thread-right-edge-background

Conversation

@SunkenInTime

@SunkenInTime SunkenInTime commented Jul 25, 2026

Copy link
Copy Markdown

Summary

  • align the dark pre-React document surface with the native Windows/workspace background
  • derive browser chrome and the Windows resize inset from the stable --app-chrome-background token instead of whichever route surface happens to be mounted

Root cause

Windows reserves a six-pixel resize inset at the right edge of the frameless window. The document background behind that inset was synchronized from main or the sidebar. During a thread transition, those route surfaces can be absent or expose a different color, leaving the inset darker than the workspace. The initial dark document color also used the older #161616 value while the current workspace/native window uses #0a0a0a.

Windows screenshots

Captured from the same isolated Windows fixture and window bounds after switching from a short thread to a long, scrollable thread.

Before (nightly baseline) After
Nightly baseline Fixed

In the fixed build, the workspace and the full six-pixel right inset both sample as rgb(10, 10, 10) above and below the scrollbar.

Verification

  • targeted vp fmt --check and vp lint for the changed files
  • pnpm --filter @t3tools/web typecheck
  • native Windows Electron pass using an isolated state directory, switching between short and long scrollable threads

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7578df68-d53e-4dcc-82c8-e65de81e010f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant