Fix Windows thread edge background#4493
Draft
SunkenInTime wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--app-chrome-backgroundtoken instead of whichever route surface happens to be mountedRoot cause
Windows reserves a six-pixel resize inset at the right edge of the frameless window. The document background behind that inset was synchronized from
mainor the sidebar. During a thread transition, those route surfaces can be absent or expose a different color, leaving the inset darker than the workspace. The initial dark document color also used the older#161616value while the current workspace/native window uses#0a0a0a.Windows screenshots
Captured from the same isolated Windows fixture and window bounds after switching from a short thread to a long, scrollable thread.
In the fixed build, the workspace and the full six-pixel right inset both sample as
rgb(10, 10, 10)above and below the scrollbar.Verification
vp fmt --checkandvp lintfor the changed filespnpm --filter @t3tools/web typecheck