fix(web): normalize compact UI geometry #4498
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -334,15 +334,16 @@ export default function ProjectScriptsControl({ | |
| <TooltipTrigger | ||
| render={ | ||
| <Button | ||
| size="icon-xs" | ||
| variant="outline" | ||
| className="@3xl/header-actions:w-auto @3xl/header-actions:px-[calc(--spacing(2)-1px)]" | ||
|
Contributor
There was a problem hiding this comment. Expanded script buttons lose compact typographyMedium Severity Switching these controls to Additional Locations (1)  Reviewed by Cursor Bugbot for commit b931602. Configure here. |
||
| aria-label={`Run ${primaryScript.name}`} | ||
| onClick={() => onRunScript(primaryScript)} | ||
| /> | ||
| } | ||
| > | ||
| <ScriptIcon icon={primaryScript.icon} /> | ||
| <span className="hidden @3xl/header-actions:ml-0.5 @3xl/header-actions:inline"> | ||
| {primaryScript.name} | ||
| </span> | ||
| </TooltipTrigger> | ||
|
|
@@ -428,11 +429,17 @@ export default function ProjectScriptsControl({ | |
| <Tooltip> | ||
| <TooltipTrigger | ||
| render={ | ||
| <Button | ||
| size="icon-xs" | ||
| variant="outline" | ||
| className="@3xl/header-actions:w-auto @3xl/header-actions:px-[calc(--spacing(2)-1px)]" | ||
| aria-label="Add action" | ||
| onClick={openAddDialog} | ||
| /> | ||
| } | ||
| > | ||
| <PlusIcon className="size-3.5" /> | ||
| <span className="hidden @3xl/header-actions:ml-0.5 @3xl/header-actions:inline"> | ||
| Add action | ||
| </span> | ||
| </TooltipTrigger> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| import { renderToStaticMarkup } from "react-dom/server"; | ||
| import { describe, expect, it } from "vite-plus/test"; | ||
| import { FlaskConicalIcon } from "lucide-react"; | ||
|
|
||
| import { Button } from "./button"; | ||
|
|
||
| describe("button geometry tokens", () => { | ||
| it("uses the shared control radius and an opaque semantic icon color", () => { | ||
| const html = renderToStaticMarkup( | ||
| <Button size="icon-xs" variant="outline" aria-label="Run tests"> | ||
| <FlaskConicalIcon /> | ||
| </Button>, | ||
| ); | ||
|
|
||
| expect(html).toContain("rounded-[var(--control-radius)]"); | ||
| expect(html).toContain("[--control-icon-color:var(--muted-foreground)]"); | ||
| expect(html).toContain("text-[var(--control-icon-color)]"); | ||
| expect(html).not.toContain("opacity-80"); | ||
| }); | ||
|
|
||
| it("keeps compact icon buttons square at every breakpoint", () => { | ||
| const html = renderToStaticMarkup( | ||
| <Button size="icon-xs" aria-label="Add action"> | ||
| <span>+</span> | ||
| </Button>, | ||
| ); | ||
|
|
||
| expect(html).toContain("size-7"); | ||
| expect(html).toContain("sm:size-6"); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -103,7 +103,12 @@ function CommandInput({ | |
| wrapperClassName?: string | undefined; | ||
| }) { | ||
| return ( | ||
| <div | ||
| className={cn( | ||
| "px-[var(--command-shell-inset)] py-1.5 [&_[data-slot=autocomplete-start-addon]]:ps-[calc(var(--command-shell-inset)+0.0625rem)] sm:*:data-[slot=autocomplete-input]:ps-[calc(var(--command-shell-inset)+1.5rem)]", | ||
|
Contributor
There was a problem hiding this comment. Command input padding never appliesMedium Severity The Reviewed by Cursor Bugbot for commit b931602. Configure here. |
||
| wrapperClassName, | ||
| )} | ||
| > | ||
| <AutocompleteInput | ||
| autoFocus | ||
| className={cn( | ||
|
|
@@ -211,7 +216,7 @@ function CommandFooter({ className, ...props }: React.ComponentProps<"div">) { | |
| return ( | ||
| <div | ||
| className={cn( | ||
| "relative flex items-center justify-between gap-2 rounded-b-[calc(var(--radius-2xl)-1px)] bg-foreground/[0.025] px-[var(--command-content-inset)] py-3 font-medium text-sm text-muted-foreground [&_[data-slot=kbd-group]]:font-sans [&_[data-slot=kbd]]:bg-foreground/[0.08] [&_[data-slot=kbd]]:text-foreground [&_[data-slot=kbd]]:ring-0", | ||
| className, | ||
| )} | ||
| data-slot="command-footer" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expanded script buttons stay cramped
Medium Severity
Switching these controls to
icon-xskeepssm:size-6width while only adding@3xl/header-actions:w-auto. Depending on stylesheet order, the fixed width can win, so when labels unhide the button stays 24px wide and the text overflows. The override also omits the oldxstext and gap sizing used by neighboring header actions.Additional Locations (1)
apps/web/src/components/ProjectScriptsControl.tsx#L431-L435Reviewed by Cursor Bugbot for commit b931602. Configure here.