Skip to content

fix(web): show Codex fast mode as a bolt#4503

Open
PixPMusic wants to merge 1 commit into
pingdotgg:mainfrom
PixPMusic:pixpmusic/fix-codex-fast-mode-indicator
Open

fix(web): show Codex fast mode as a bolt#4503
PixPMusic wants to merge 1 commit into
pingdotgg:mainfrom
PixPMusic:pixpmusic/fix-codex-fast-mode-indicator

Conversation

@PixPMusic

@PixPMusic PixPMusic commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • extend feat(web): show fast mode as a bolt instead of a "Normal" label #4488’s compact fast-mode indicator to Codex service tiers
  • hide Standard from the joined trigger label and show the bolt when Fast is selected
  • preserve labels for distinct tiers such as Flex and keep single-trait fallbacks readable
  • derive the fast-mode state from provider descriptors and cover the Codex cases with regression tests

Verification

  • pnpm exec vp test run apps/web/src/components/chat/TraitsPicker.test.ts — 9 tests passed
  • pnpm --filter @t3tools/web typecheck
  • targeted formatting and lint checks for the two changed files
  • isolated web verification with GPT-5.6-Sol: Fast renders the bolt beside Medium; Standard renders only Medium

Note

Low Risk
UI-only label/icon logic in the chat traits trigger with unit test coverage; no auth, API, or persistence changes.

Overview
Extends the traits picker trigger so Codex serviceTier (Standard/Fast) uses the same compact fast-mode UX as the boolean fastMode trait: Standard is omitted from the joined label, Fast shows the bolt instead of text, and tiers like Flex still appear in the label.

buildTraitsTriggerDisplay now infers fast-mode state from provider descriptors (boolean or Standard/Fast service tier) instead of taking a separate fastModeEnabled argument; when service tier is the only trait, it still falls back to readable Standard / Fast text without the icon.

Regression tests cover Codex service-tier label and bolt behavior alongside existing Claude fast-mode cases.

Reviewed by Cursor Bugbot for commit 7046624. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Show bolt icon for Codex Fast service tier in TraitsPicker

  • buildTraitsTriggerDisplay now infers fast-mode state from two sources: a boolean fastMode descriptor, or a serviceTier select where "Fast" shows the bolt and "Standard" hides it.
  • Non-fast/non-standard tiers (e.g. Flex) contribute their label to the traits list instead of triggering the bolt.
  • getSelectedTraits no longer returns fastModeEnabled; fast-mode detection is fully delegated to buildTraitsTriggerDisplay.
  • Behavioral Change: callers that previously consumed fastModeEnabled from getSelectedTraits must now rely on buildTraitsTriggerDisplay to determine fast-mode state.

Macroscope summarized 7046624.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 32c9941c-64c1-480a-8e15-73a5e11306fa

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Jul 25, 2026
@macroscopeapp

macroscopeapp Bot commented Jul 25, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved

This PR makes a small, well-tested UI display change to show a lightning bolt icon for Codex's fast service tier. The changes are purely presentational, self-contained within the TraitsPicker component, and include comprehensive test coverage.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant