fix(web): show Codex fast mode as a bolt#4503
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved This PR makes a small, well-tested UI display change to show a lightning bolt icon for Codex's fast service tier. The changes are purely presentational, self-contained within the TraitsPicker component, and include comprehensive test coverage. You can customize Macroscope's approvability policy. Learn more. |
Summary
Verification
pnpm exec vp test run apps/web/src/components/chat/TraitsPicker.test.ts— 9 tests passedpnpm --filter @t3tools/web typecheckMedium; Standard renders onlyMediumNote
Low Risk
UI-only label/icon logic in the chat traits trigger with unit test coverage; no auth, API, or persistence changes.
Overview
Extends the traits picker trigger so Codex
serviceTier(Standard/Fast) uses the same compact fast-mode UX as the booleanfastModetrait: Standard is omitted from the joined label, Fast shows the bolt instead of text, and tiers like Flex still appear in the label.buildTraitsTriggerDisplaynow infers fast-mode state from provider descriptors (boolean or Standard/Fast service tier) instead of taking a separatefastModeEnabledargument; when service tier is the only trait, it still falls back to readable Standard / Fast text without the icon.Regression tests cover Codex service-tier label and bolt behavior alongside existing Claude fast-mode cases.
Reviewed by Cursor Bugbot for commit 7046624. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Show bolt icon for Codex Fast service tier in
TraitsPickerbuildTraitsTriggerDisplaynow infers fast-mode state from two sources: a booleanfastModedescriptor, or aserviceTierselect where "Fast" shows the bolt and "Standard" hides it.getSelectedTraitsno longer returnsfastModeEnabled; fast-mode detection is fully delegated tobuildTraitsTriggerDisplay.fastModeEnabledfromgetSelectedTraitsmust now rely onbuildTraitsTriggerDisplayto determine fast-mode state.Macroscope summarized 7046624.