Add unit tests for executeApplyStage, executePlanStage, and executeRo… - #7109
Open
vishnukothakapu wants to merge 2 commits into
Open
Add unit tests for executeApplyStage, executePlanStage, and executeRo…#7109vishnukothakapu wants to merge 2 commits into
vishnukothakapu wants to merge 2 commits into
Conversation
Contributor
|
👋 Hi @vishnukothakapu, welcome to PipeCD and thanks for opening your first pull request! We’re really happy to have you here Before your PR gets merged, please check a few important things below. Helpful resources
DCO Sign-offAll commits must include a In case you forget to sign-off your commit(s), follow these steps: For the last commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/master
git push --force-with-leaseRun checks locallyBefore pushing updates, please run: make checkThis runs the same checks as CI and helps catch issues early. 💬 Need help?If anything is unclear, feel free to ask in this PR or join us on the CNCF Slack in the #pipecd channel. Thanks for contributing to PipeCD! ❤️ |
vishnukothakapu
force-pushed
the
add-terraform-stage-tests
branch
3 times, most recently
from
August 3, 2026 08:05
81c598e to
c009364
Compare
…llbackStage Signed-off-by: Vishnu Kothakapu <vishnukothakapu27@gmail.com>
Signed-off-by: Vishnu Kothakapu <vishnukothakapu27@gmail.com>
vishnukothakapu
force-pushed
the
add-terraform-stage-tests
branch
from
August 3, 2026 08:06
c009364 to
37b17be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does: Adds unit tests for three stage-execution functions in the pipedv1 Terraform plugin:
executeApplyStage,executePlanStage, andexecuteRollbackStage. It also removes the // TODO: add test comments from their respective source files.The new test suites cover the most common pre-execution failure scenarios (such as an unavailable
StageLogPersisteracross all stages, and an emptyCommitHashduring the first deployment rollback).Why we need it: These functions are core to the Terraform plugin's deployment lifecycle but were entirely untested. Adding tests here improves confidence in the pipedv1 plugin architecture, resolves long-standing TODOs, and aligns with the project's existing testing patterns seen in
plugin_test.go.Which issue(s) this PR fixes: Fixes #7108
Does this PR introduce a user-facing change?: