Skip to content

noconsul changes#58

Open
scriptory wants to merge 13 commits intomainfrom
private/tdell/noconsul-rebased
Open

noconsul changes#58
scriptory wants to merge 13 commits intomainfrom
private/tdell/noconsul-rebased

Conversation

@scriptory
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread vouch/cert_utils.py Fixed
Comment thread vouch/cert_utils.py Fixed
Comment thread vouch/common_cert.py Dismissed
Comment thread vouch/common_cert.py Dismissed
Comment thread vouch/common_cert.py Dismissed
Comment thread vouch/common_cert.py Dismissed
@gauravgavhane05 gauravgavhane05 requested a review from a team April 7, 2026 05:32
Copy link
Copy Markdown

@estenrye estenrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need unnecessary CLI tools in the image?
Can we eliminate the surface area of the image and move these tools to a debug container that can be launched via kubectl when it is needed?

Nothing here is critical and could be addressed in a follow on PR as long as we get Technical Debt work items on the board and prioritize addressing them in a timely manner.

Comment thread container/Dockerfile
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all of these tools needed in the image?

Comment thread vouch/common_cert.py Dismissed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants