Skip to content

fix: enforce strict python baseline < 3.13 #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
matthewmcneill wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: enforce strict python baseline < 3.13 #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
083f392
fix: enforce strict python baseline < 3.13
matthewmcneill Apr 26, 2026
853f784
Refactor Python version check to be configurable
matthewmcneill Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ node_modules
dist
yarn.lock
package-lock.json
platformio-node-helpers-11.3.0.tgz
17 changes: 16 additions & 1 deletion src/installer/get-python.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,8 @@ jjxDah2nGN59PRbxYvnKkKj9
-----END CERTIFICATE-----
`;

export async function findPythonExecutable() {
export async function findPythonExecutable(options = {}) {
const maxPythonVersion = options.maxPythonVersion || process.env.PLATFORMIO_MAX_PYTHON_VERSION || '3.13';
const exenames = proc.IS_WINDOWS ? ['python.exe'] : ['python3', 'python'];
const envPath = process.env.PLATFORMIO_PATH || process.env.PATH;
const errors = [];
Expand All @@ -116,6 +117,20 @@ export async function findPythonExecutable() {
fs.existsSync(executable) &&
(await callInstallerScript(executable, ['check', 'python']))
) {
// Verify Python version does not exceed maximum stable baseline
try {
const versionCheck = await proc.getCommandOutput(executable, [
'-c',
`import sys; print("1" if sys.version_info < tuple(map(int, "${maxPythonVersion}".split("."))) else "0")`
]);
if (versionCheck.trim() !== '1') {
console.warn(`Python at ${executable} exceeds max supported version (>= ${maxPythonVersion})`);
continue; // Reject bleeding edge and force fallback loop
}
} catch (err) {
console.warn(`Failed to verify Python version structure for ${executable}:`, err);
continue;
}
return executable;
}
} catch (err) {
Expand Down