Added: info icons linking to the documentation for several sections in the settings screen. - #322
Added: info icons linking to the documentation for several sections in the settings screen.#322Dan0sz wants to merge 1 commit into
Conversation
…n the settings screen.
📝 WalkthroughWalkthroughThe settings API now provides reusable documentation links with contextual titles. Six settings groups configure documentation URLs for affiliate links, query parameters, dashboard statistics, user roles, and toolbar settings. The changelog documents these links. ChangesSettings documentation links
Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@coderabbitai review |
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/Admin/Settings/API.php`:
- Around line 112-117: Add a stable accessible name to the icon-only anchor in
the settings markup by applying an aria-label derived from $title, while
preserving the existing aria-hidden SVG and link behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: fe8386af-dc5e-40ca-8e1e-cf79ed69660c
📒 Files selected for processing (3)
readme.txtsrc/Admin/Settings/API.phpsrc/Admin/Settings/Page.php
| <a class="inline-flex items-center leading-none" href="<?php echo esc_url( $url ); ?>" rel="noreferrer" target="_blank" title="<?php echo esc_attr( $title ); ?>"> | ||
| <svg xmlns="http://www.w3.org/2000/svg" class="text-gray-400 w-6 h-6 leading-none" stroke="currentColor" aria-hidden="true" fill="none" viewBox="0 0 24 24" stroke-width="1.5"> | ||
| <path stroke-linecap="round" stroke-linejoin="round" | ||
| d="M11.25 11.25l.041-.02a.75.75 0 011.063.852l-.708 2.836a.75.75 0 001.063.853l.041-.021M21 12a9 9 0 11-18 0 9 9 0 0118 0zm-9-3.75h.008v.008H12V8.25z"></path> | ||
| </svg> | ||
| </a> |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Add a stable accessible name to the icon-only link.
The anchor has no text, and its only child SVG is aria-hidden. Its accessible name therefore depends on the title fallback. W3C notes that support for this fallback varies across assistive technologies. Add an aria-label or visually hidden text based on $title. (w3.org)
Proposed fix
- <a class="inline-flex items-center leading-none" href="<?php echo esc_url( $url ); ?>" rel="noreferrer" target="_blank" title="<?php echo esc_attr( $title ); ?>">
+ <a class="inline-flex items-center leading-none" href="<?php echo esc_url( $url ); ?>" rel="noreferrer" target="_blank" aria-label="<?php echo esc_attr( $title ); ?>" title="<?php echo esc_attr( $title ); ?>">📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <a class="inline-flex items-center leading-none" href="<?php echo esc_url( $url ); ?>" rel="noreferrer" target="_blank" title="<?php echo esc_attr( $title ); ?>"> | |
| <svg xmlns="http://www.w3.org/2000/svg" class="text-gray-400 w-6 h-6 leading-none" stroke="currentColor" aria-hidden="true" fill="none" viewBox="0 0 24 24" stroke-width="1.5"> | |
| <path stroke-linecap="round" stroke-linejoin="round" | |
| d="M11.25 11.25l.041-.02a.75.75 0 011.063.852l-.708 2.836a.75.75 0 001.063.853l.041-.021M21 12a9 9 0 11-18 0 9 9 0 0118 0zm-9-3.75h.008v.008H12V8.25z"></path> | |
| </svg> | |
| </a> | |
| <a class="inline-flex items-center leading-none" href="<?php echo esc_url( $url ); ?>" rel="noreferrer" target="_blank" aria-label="<?php echo esc_attr( $title ); ?>" title="<?php echo esc_attr( $title ); ?>"> | |
| <svg xmlns="http://www.w3.org/2000/svg" class="text-gray-400 w-6 h-6 leading-none" stroke="currentColor" aria-hidden="true" fill="none" viewBox="0 0 24 24" stroke-width="1.5"> | |
| <path stroke-linecap="round" stroke-linejoin="round" | |
| d="M11.25 11.25l.041-.02a.75.75 0 011.063.852l-.708 2.836a.75.75 0 001.063.853l.041-.021M21 12a9 9 0 11-18 0 9 9 0 0118 0zm-9-3.75h.008v.008H12V8.25z"></path> | |
| </svg> | |
| </a> |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/Admin/Settings/API.php` around lines 112 - 117, Add a stable accessible
name to the icon-only anchor in the settings markup by applying an aria-label
derived from $title, while preserving the existing aria-hidden SVG and link
behavior.
Summary by CodeRabbit