feat: add new Open Finance credit card fields#94
Open
cernadasjuan wants to merge 1 commit into
Open
Conversation
Pluggy's backend (commons 6.48.0) added new Open Finance credit-card fields to the canonical types, which the Pluggy API now returns in credit-card responses. This models them in the Java SDK so consumers can read them. - CreditData: add brandAdditionalInfo and disaggregatedCreditLimits. - DisaggregatedCreditLimit (new): lineName (CreditCardLimitLineName), limitAmountReason, customizedLimitAmount, customizedLimitAmountCurrencyCode. - TransactionCreditCardMetadata: add feeType, feeTypeAdditionalInfo, otherCreditsType, otherCreditsAdditionalInfo. - New enums CreditCardLimitLineName, CreditCardAccountFeeType and CreditCardAccountOtherCreditType, following the existing Gson @SerializedName enum style. currencyCode fields are modeled as String, matching the SDK's existing convention (no CurrencyCode type exists in this SDK). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cernadasjuan
force-pushed
the
feat/of-credit-card-fields
branch
from
90bc9f9 to
05c7b7a
Compare
cernadasjuan
changed the title
Contributor
Author
|
@claude review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Models the new Open Finance credit-card fields added to Pluggy's canonical types in commons 6.48.0, so SDK consumers can read them off credit-card responses.
CreditDatabrandAdditionalInfo(String) — free text to specify the brand category when brand isOTHER.disaggregatedCreditLimits(List<DisaggregatedCreditLimit>) — per-line credit limit breakdown.DisaggregatedCreditLimit(new class)lineName(CreditCardLimitLineName)limitAmountReason(String) — reason the reported total limit amount is zero.customizedLimitAmount(Double) — limit amount customized by the customer.customizedLimitAmountCurrencyCode(String) — currency of the customized limit amount.TransactionCreditCardMetadatafeeType(CreditCardAccountFeeType)feeTypeAdditionalInfo(String)otherCreditsType(CreditCardAccountOtherCreditType)otherCreditsAdditionalInfo(String)@SerializedNamestyle, matching existing credit-card enums):CreditCardLimitLineName:CREDITO_A_VISTA,CREDITO_PARCELADO,SAQUE_CREDITO_BRASIL,SAQUE_CREDITO_EXTERIOR,EMPRESTIMO_CARTAO_CONSIGNADO,OUTROSCreditCardAccountFeeType:ANNUAL_FEE,ATM_WITHDRAWAL_DOMESTIC,ATM_WITHDRAWAL_INTERNATIONAL,EMERGENCY_CREDIT_EVALUATION,CARD_REISSUE,BILL_PAYMENT_FEE,SMS,OTHERCreditCardAccountOtherCreditType:REVOLVING_CREDIT,BILL_INSTALLMENT,LOAN,OTHERNotes
CreditCard.java(credit-card data lives inCreditData, nested inAccount) and noCreditCardMetadata.java(it isTransactionCreditCardMetadata). Fields were added to those existing classes.CurrencyCodetype and consistently models currency codes asString(e.g.Account.currencyCode,Bill.totalAmountCurrencyCode), socustomizedLimitAmountCurrencyCodeis modeled asString.Test plan
mvn -q compile— compiles cleanly.mvn -B test— 4 unit tests pass (BUILD SUCCESS).🤖 Generated with Claude Code