Fix - Convert empty dropdown value (-1) to null on form submission#1196
Merged
Conversation
Rom1-B
reviewed
May 12, 2026
Co-authored-by: Romain B. <8530352+Rom1-B@users.noreply.github.com>
stonebuzz
approved these changes
May 13, 2026
Rom1-B
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
When a form containing a Fields dropdown question (either via
PluginFieldsQuestionTypeor the nativeQuestionTypeItemDropdown) is submitted without a value selected, GLPI sends-1(or0) as theitems_id. This value was passed as-is to the INSERT query, but the underlying column isINT UNSIGNED, causing a MySQL "Out of range value" error and preventing ticket creation.Fix: In
applyConfiguratedValueToInputUsingAnswers(), anyitems_id ≤ 0is now converted tonullbefore being added to the input, consistent with how GLPI core handles this (seeEntityFieldStrategy).