refactor: migrate config form to Twig template#340
Open
giovanny07 wants to merge 2 commits intopluginsGLPI:mainfrom
Open
refactor: migrate config form to Twig template#340giovanny07 wants to merge 2 commits intopluginsGLPI:mainfrom
giovanny07 wants to merge 2 commits intopluginsGLPI:mainfrom
Conversation
Replace raw HTML echo statements in PluginTagConfig::showConfigForm() with a Twig template using Bootstrap 5 card layout and fields_macros, consistent with the rest of the plugin's GLPI 11 forms.
stonebuzz
requested changes
Mar 31, 2026
| <h3 class="card-title">{{ __('Tag Management', 'tag') }}</h3> | ||
| </div> | ||
|
|
||
| <form method="post" action="{{ form_action }}"> |
Contributor
There was a problem hiding this comment.
With Twig, you don’t need to manually handle the <form> DOM.
You simply need to add the following line at the top of your file:
{% extends "pages/setup/general/base_form.html.twig" %}This will automatically manage the form structure, including the “Save” button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the raw HTML
echostatements inPluginTagConfig::showConfigForm()with a Twig template (templates/forms/config.html.twig) using Bootstrap 5 card layout andfields_macros, consistent with the rest of the plugin'sGLPI 11 forms.
No functional changes — only presentation layer refactor.