Fixed vertical knock back not matching vanilla#5986
Open
JavierLeon9966 wants to merge 2 commits intopmmp:stablefrom
Open
Fixed vertical knock back not matching vanilla#5986JavierLeon9966 wants to merge 2 commits intopmmp:stablefrom
JavierLeon9966 wants to merge 2 commits intopmmp:stablefrom
Conversation
Member
|
Are you sure this isn't a randomized value? |
Contributor
Author
Yes. I tested multiple times and that value was always logged. |
Contributor
|
dragonfly also use this value. |
Member
|
I feel like there's some physics that we're missing here. Java uses 0.4, and Bedrock mimics Java in this regard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
I tested the knockback in a vanilla server using gophertunnel by logging the output of
SetActorMotionPacketand it turns out the player has a vertical knockback limit of 0.3608.Relevant issues
None
Changes
API changes
None
Behavioural changes
None
Backwards compatibility
None
Follow-up
None
Tests
Screen_Recording_20230810_154530_Minecraft.mp4