Skip to content

Implemented Void Generator#6960

Open
remminiscent wants to merge 8 commits intopmmp:minor-nextfrom
remminiscent:void-gen
Open

Implemented Void Generator#6960
remminiscent wants to merge 8 commits intopmmp:minor-nextfrom
remminiscent:void-gen

Conversation

@remminiscent
Copy link
Copy Markdown
Contributor

Adds a "void" type generator.

Related issues & PRs

Changes

void gen 👍

Tests

make default level type to "void" and make pm generate a world, join, and see
image

@remminiscent remminiscent requested a review from a team as a code owner December 24, 2025 12:27
Comment thread src/world/generator/VoidGenerator.php Outdated
Comment thread src/world/generator/VoidGenerator.php Outdated
Comment thread src/world/generator/VoidGenerator.php Outdated
Comment thread src/world/generator/VoidGenerator.php Outdated
Comment thread src/world/generator/VoidGenerator.php
Comment thread src/world/generator/VoidGenerator.php Outdated
@dktapps dktapps added Category: Gameplay Related to Minecraft gameplay experience Status: Waiting on Author Type: Enhancement Contributes features or other improvements to PocketMine-MP labels Dec 24, 2025
@remminiscent
Copy link
Copy Markdown
Contributor Author

256 256 spawns you in between 4 chunks, does that mean i need to generate 4 base chunks?

@dktapps
Copy link
Copy Markdown
Member

dktapps commented Dec 25, 2025

I wouldn't do a base chunk at all. Just create a new one and do the appropriate work depending on the coordinate range available. No need to store anything since this doesn't need to copy paste terrain

Comment thread src/world/generator/VoidGenerator.php Outdated
@remminiscent
Copy link
Copy Markdown
Contributor Author

off-topic, but did MrCakeSlayer forward you a message about smth regarding a phpstorm OSS partnership? if not, you can apply pocketmine to be a OSS partner of JetBrains, which will grant contributors a free license of PHPStorm (if you havent noticed, i need it badly for PRs)

@dktapps
Copy link
Copy Markdown
Member

dktapps commented Dec 26, 2025

off-topic, but did MrCakeSlayer forward you a message about smth regarding a phpstorm OSS partnership? if not, you can apply pocketmine to be a OSS partner of JetBrains, which will grant contributors a free license of PHPStorm (if you havent noticed, i need it badly for PRs)

I'm aware of the program, but never applied for it since I've pretty much always been making a bit of money working on servers and I wasn't sure how that would interact with the partnership. Easy enough for me to just expense it anyway.

In any case, I could be wrong, but I'm fairly sure you'd have to be a member of the PMMP organisation to benefit from that even if we were partnered.

They do also have free student licenses if that would work for you.

If you hit me up on Discord we can discuss this more privately

@remminiscent
Copy link
Copy Markdown
Contributor Author

alright. when you got time, checkout the new commit on this PR and lmk if it looks good to you

Comment thread src/world/generator/VoidGenerator.php Outdated
Copy link
Copy Markdown
Member

@dktapps dktapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing this to Bedrock, the behaviour doesn't match. In Bedrock, the platform is centered on x=0,z=0, and generates at y=-64. The platform also extends from -16 to +16 inclusive (so 33 x 33 blocks) and the center block is cobblestone.

@remminiscent
Copy link
Copy Markdown
Contributor Author

lgtm 😆

@dktapps
Copy link
Copy Markdown
Member

dktapps commented Jan 2, 2026

Code seems fine, I'll test it tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Category: Gameplay Related to Minecraft gameplay experience Type: Enhancement Contributes features or other improvements to PocketMine-MP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants