feat(skills): add pocketjs-review-pr community review skill - #194
Merged
Conversation
Distills the #189 review into a repeatable method: reproduce the bug on base over a widened input matrix, check the PR's load-bearing claims against the dependency source in node_modules, sweep for drift and rot (hand-maintained lists, incomplete cache keys, comments that overclaim, unreachable modules), run `bun run test` + tsc as the gate this repo has no CI for, push the findings onto the contributor's branch, and squash-merge behind a review comment that records the evidence. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reviewing #189 produced a method worth keeping: the PR's own description was a hypothesis, the real findings came from reproducing the bug on
mainacross a wider input matrix than the PR tested, checking its load-bearing claims againstnode_modules/source, and asking a fixed set of drift/rot questions. Two of those questions found real issues (a hand-maintained cache-key list that reintroduced the very rot it patched, and an anchored regex that only handled the single-comment shape), which then shipped as a commit on the contributor's branch rather than a round-trip.What
skills/pocketjs-review-pr/SKILL.md— a ten-step workflow plus gotchas, carrying the repo-specific facts that make the difference between a review and a rubber stamp:.github/workflows/is deploy + esp32p4 + release), sogh pr checksreporting "no checks reported" is normal and the local run is the gate. Barebun testis not that gate — it pulls in emulator/hardware harnesses;bun run testis.git checkout main(held by~/code/pocketjs), andbun tools/build.ts herofirst so tests can resolveframework/src/styles.generated.ts.git show main:<file> > <file>.base.ts, absolute imports from the scratchpad, one line per case).maintainerCanModifyforks.Validation
Markdown only — no code paths touched. Frontmatter matches the four existing skills, length (159 lines) sits inside their range, and
bun test tests/npm-package.test.ts tests/release-check.test.tspasses (7/7):skills/is not part of the npmfilessurface, so the packaging governance is unaffected.🤖 Generated with Claude Code