Add build version info to kernel info reply#1333
Merged
Merged
Conversation
lionel-
approved these changes
Jul 15, 2026
| input_prompt: kernel_info.input_prompt.clone(), | ||
| continuation_prompt: kernel_info.continuation_prompt.clone(), | ||
| build_version: Some(String::from(crate::BUILD_VERSION)), | ||
| commit: Some(String::from(env!("BUILD_GIT_HASH"))), |
Contributor
There was a problem hiding this comment.
For consistency we might want to do the same for git commit as you did for build version with Davis in #1188
Contributor
There was a problem hiding this comment.
If you're asking for crate::BUILD_GIT_HASH to be a constant alongside crate::BUILD_VERSION, then yea I'd be in favor of that
DavisVaughan
approved these changes
Jul 15, 2026
| input_prompt: kernel_info.input_prompt.clone(), | ||
| continuation_prompt: kernel_info.continuation_prompt.clone(), | ||
| build_version: Some(String::from(crate::BUILD_VERSION)), | ||
| commit: Some(String::from(env!("BUILD_GIT_HASH"))), |
Contributor
There was a problem hiding this comment.
If you're asking for crate::BUILD_GIT_HASH to be a constant alongside crate::BUILD_VERSION, then yea I'd be in favor of that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a couple more Positron-specific fields to the
kernel_info_reply, with the goal of making it possible for Positron to know exactly what version of ark it's dealing with, without making additional RPCs.Needed for posit-dev/positron#14407.