fix(aks): stable far-future force-upgrade expiry to stop perpetual dry-run diff#339
Open
stevenolen wants to merge 1 commit into
Open
fix(aks): stable far-future force-upgrade expiry to stop perpetual dry-run diff#339stevenolen wants to merge 1 commit into
stevenolen wants to merge 1 commit into
Conversation
…l diff The AKS force-upgrade override set upgradeSettings.overrideSettings.until to time.Now().Add(24h), a value recomputed on every run. Pulumi therefore saw a diff on that field on every preview/apply for clusters with force_maintenance enabled, so the step never converged. Replace the now-relative value with a fixed far-future constant (2035-01-01T00:00:00Z). The override stays permanently armed (ForceUpgrade still true, so PodDisruptionBudgets never block a maintenance upgrade) but the input is now stable and converges. Drop the now-unused time import.
amdove
approved these changes
Jul 8, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
AKS clusters with
force_maintenanceenabled showed a perpetual dry-run diff onupgradeSettings.overrideSettings.until. The value wastime.Now().Add(24h), recomputed on every run, so it never matched state and the step never converged.Change
untilto a fixed far-future constant (2035-01-01T00:00:00Z) so the value is stable and converges after one apply.ForceUpgradeis still true, so PodDisruptionBudgets never block a maintenance upgrade.timeimport.Testing
just cli,just check-go,just test-lib,just formatall pass.untilnow renders as the fixed constant (one-time reconcile) with no other change to the step.Follow-up
untilthis far in the future (confirm there is no max-window clamp/rejection on the override expiry). If clamped, a nearer but still-stable date can be used.