Refresh functions too#23
Open
positron96 wants to merge 18 commits into
Open
Conversation
positron96
force-pushed
the
feature/refresh_functions
branch
2 times, most recently
from
8819ce7 to
d66a92e
Compare
…the C++ standard. Compiles, but NOT TESTED.
…stream manipulation
Does not compile due to bit timer ISR not IRAM-able
Did not check
positron96
force-pushed
the
feature/refresh_functions
branch
from
d66a92e to
0599ea7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only speed and direction is periodically sent to rails now.
Extend this functionality to functions too.
Lets start with F0..F12.
Along the way, DCC RegisterList class needs to be rewritten or removed. Otherwise it will need to contain not a single packet per slot, but multiple, and will need to have logic to prioritize. Since it has raw DCC packets, it doesn't have information to know what packets to choose. On the other hand, CommandStation does contain this information and already iterates over slots, so it makes sense to move queue generation there.