Skip to content

os_ops: pathsep and get_name are stable #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitry-lipetsk merged 1 commit into from
Jul 8, 2026
+3 −20
Merged

os_ops: pathsep and get_name are stable #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/local_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,14 +506,7 @@ def path_exists(self, path: str) -> bool:

@property
def pathsep(self) -> str:
os_name = self.get_name()
if os_name == "posix":
pathsep = ":"
elif os_name == "nt":
pathsep = ";"
else:
raise Exception("Unsupported operating system: {}".format(os_name))
return pathsep
return os.path.pathsep

def mkdtemp(self, prefix: typing.Optional[str] = None) -> str:
assert prefix is None or type(prefix) is str
Expand Down
14 changes: 2 additions & 12 deletions src/remote_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,10 +421,7 @@ def set_env(
return

def get_name(self):
cmd = 'python3 -c "import os; print(os.name)"'
stdout = self.exec_command(cmd, encoding=get_default_encoding())
assert type(stdout) is str
return stdout.strip()
return "posix"

# Work with dirs
def makedirs(
Expand Down Expand Up @@ -606,14 +603,7 @@ def path_exists(self, path: str) -> bool:

@property
def pathsep(self) -> str:
os_name = self.get_name()
if os_name == "posix":
pathsep = ":"
elif os_name == "nt":
pathsep = ";"
else:
raise Exception("Unsupported operating system: {}".format(os_name))
return pathsep
return posixpath.pathsep

def mkdtemp(self, prefix: typing.Optional[str] = None) -> str:
"""
Expand Down