Work around infrequent crash when pen enters proximity on Windows#6752
Merged
Conversation
smoogipoo
approved these changes
May 20, 2026
bdach
approved these changes
May 20, 2026
Collaborator
bdach
left a comment
There was a problem hiding this comment.
Claim that on Windows SDL_PEN_DEVICE_TYPE_UNKNOWN is always returned appears to check out against my sample size of one (1) osu!-branded XP-Pen Deco Fun XS.
Of particular note I could not even get SDL_EVENT_PEN_PROXIMITY_{IN,OUT} to trigger until XP-Pen drivers were present. So possibly this is due to errant drivers. We will likely never know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hard-codes the pen type on Windows to
TabletPenDeviceType.Unknown. There is no change in functionality as SDL already reports all pens on Windows asSDL_PEN_DEVICE_TYPE_UNKNOWN.The crash is fixed by not calling
SDL_GetPenDeviceType(), which may sometimes error out with "Invalid pen instance ID".I also considered storing the last pen type and using that in the error case, but I found it too hacky, it doesn't fix the underlying issue and increases complexity.