Rework visor expansion#130
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reworks the launcher “visor” behavior by removing the explicit expansion animation state and instead laying out only the collapsed vs expanded states, letting transform updates produce the visual transition implicitly. It also shifts “anchor” tracking to be driven by focus transitions rather than a dedicated expansion effect.
Changes:
- Removed visor expansion animation plumbing (
UpdateLauncherExpansioneffect,visor_expansion_animation, and associated presenter state). - Introduced a per-launcher “focus anchor” mechanism and updates it on keyboard-focus transitions to choose the visor anchor when nothing is focused in that launcher.
- Refactored focus-transition handling to centralize effect application/forwarding and added a few clarifying comments / dictionary entries.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
desktop/src/projects/launcher_presenter.rs |
Removes visor expansion animation state and uses a focus-anchor-based collapsed/expanded layout path. |
desktop/src/desktop_system/layout_state.rs |
Adds clarifying comments around child placement and size-change detection. |
desktop/src/desktop_system/layout_effects.rs |
Removes UpdateLauncherExpansion effect scheduling/handling and exposes instance_launcher to sibling modules. |
desktop/src/desktop_system/focus_input.rs |
Centralizes focus transition handling and updates launcher focus anchors on keyboard focus changes. |
desktop/src/desktop_system/effects.rs |
Removes the UpdateLauncherExpansion effect variant. |
desktop/src/desktop_system.rs |
Drops now-unneeded focus-resolution logic from apply_animations and documents deferred focus relayout tracking. |
.harper-dictionary.txt |
Adds project-specific terms to the spellcheck dictionary. |
.github/copilot-instructions.md |
Adds a guideline about keeping intra-function comments concise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There wasn't a clear separation between layout and animation. The non obvious solution was to avoid the expansion animation and layout the collapsed and expanded states only. After that, animation effects were caused implicitly by the transform updates which look the same.