Fix time command losing quoted arguments when re-parsing#286
Open
Fix time command losing quoted arguments when re-parsing#286
Conversation
The `time` builtin joined its arguments with spaces and re-parsed them,
which destroyed quoting information. For example, `time python -c "import torch"`
would pass just `import` to Python instead of `import torch`, and
`time python -c "print('ok')"` would fail to parse due to unquoted parentheses.
Fix by shell-quoting arguments that contain whitespace or special characters
before joining and re-parsing.
https://claude.ai/code/session_01PQyPNXA8mZKTLkNfytRunv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timebuiltin joined its arguments withargs.join(" ")and re-parsed the result, which destroyed all quoting informationtime python -c "import torch"would pass justimportto Python (truncating the argument)time python -c "print('ok')"would fail with a shell parse error due to unquoted parenthesesTest plan
time_preserves_quoted_argstest covering double-quoted args, single-quoted args, and args with special characters like parentheseshttps://claude.ai/code/session_01PQyPNXA8mZKTLkNfytRunv