Add Local Network Access to iframe allow#4182
Conversation
See https://learn.microsoft.com/en-us/deployedge/ms-edge-local-network-access for details. This still yields to the browser on whether or not to allow the actual request, but it adds the possibility to interface with a local host via CORS requests from within the iframe.
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
To add some motivation for the change: I maintain a p5 library to interface with ComfyUI, which is typically running on local, GPU-equipped machines that practitioners remotely access from their laptops. I have been using the p5 web editor in my workshops, but recent Chrome changes surrounding Local Network Access restrictions broke this workflow when using the web editor. |
|
@raclim @khanniie Any chance this could be reviewed/included? I would like to use the p5 Web Editor at NYU Shanghai's high school summer program, which begins on July 13. We require this change because the new Local Network Access restrictions in Chromium-based browsers have broken the ability to use the web editor in tandem with local infrastructure (for example, for generative AI experiments running on GPU-equipped machines that students can use). |
Issue:
See https://learn.microsoft.com/en-us/deployedge/ms-edge-local-network-access for details. This still yields to the browser on whether or not to allow the actual request, but it adds the possibility to interface with a local host via CORS requests from within the iframe.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123