fix mismatch of filename#4197
Open
VaibhavNarayann wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4021
Downloading a project with its default (unedited) name worked correctly, the zip filename matched. However, after renaming the project, downloading it still produced a zip file with the old/default name instead of the updated one.
fix:
In server/controllers/project.controller.js, changed the zip filename generation to use project.name instead of project.slug:
Testing
-Downloaded a project with its default name, filename matched, as before.
-Renamed the project, then downloaded it, zip filename now correctly reflects the updated name.
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123