Skip to content

fix mismatch of filename#4197

Open
VaibhavNarayann wants to merge 1 commit into
processing:developfrom
VaibhavNarayann:fix/Match-downloaded-filename
Open

fix mismatch of filename#4197
VaibhavNarayann wants to merge 1 commit into
processing:developfrom
VaibhavNarayann:fix/Match-downloaded-filename

Conversation

@VaibhavNarayann

Copy link
Copy Markdown
Contributor

Fixes #4021

Downloading a project with its default (unedited) name worked correctly, the zip filename matched. However, after renaming the project, downloading it still produced a zip file with the old/default name instead of the updated one.

fix:

In server/controllers/project.controller.js, changed the zip filename generation to use project.name instead of project.slug:

Testing

-Downloaded a project with its default name, filename matched, as before.
-Renamed the project, then downloaded it, zip filename now correctly reflects the updated name.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • has no typecheck errors (npm run typecheck)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
  • meets the standards outlined in the accessibility guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Downloaded Filename Does Not Match Sketch Name

1 participant