GSOC-E2E-1 (remake): Init Playwright, Sketch execution test, and new E2e Test workflow#4199
Open
clairep94 wants to merge 7 commits into
Open
GSOC-E2E-1 (remake): Init Playwright, Sketch execution test, and new E2e Test workflow#4199clairep94 wants to merge 7 commits into
clairep94 wants to merge 7 commits into
Conversation
Collaborator
Author
|
/e2e |
clairep94
force-pushed
the
clairep-gsoc_e2e_testing_setup
branch
8 times, most recently
from
d75dccf to
60d6ad2
Compare
Geethegreat
added a commit
to Geethegreat/p5.js-web-editor
that referenced
this pull request
Jul 3, 2026
…or checkpoint Mentor's passing PR (processing#4199) confirms the outer app shell renders fast and reliably (skip link, header, editor-holder container) — the slow/flaky part is specifically CodeMirror becoming interactive inside that shell. Adopts the faster skip-link wait for the mundane readiness check, and adds a performance.getEntriesByType('resource') dump sorted by duration right at the CodeMirror checkpoint so we can see which specific request/asset is the bottleneck instead of guessing. Also uploads the server's app.log unconditionally to see backend-side behavior during that window.
clairep94
force-pushed
the
clairep-gsoc_e2e_testing_setup
branch
2 times, most recently
from
f84fde7 to
c18ec6b
Compare
added 5 commits
July 4, 2026 22:00
- triggers on workflow dispatch, PR if from GSOC, and comment if from maintainers - uploads playwright artifacts upon failure
clairep94
force-pushed
the
clairep-gsoc_e2e_testing_setup
branch
from
47e29e8 to
9913751
Compare
clairep94
changed the title
clairep94
commented
Jul 4, 2026
| contains(fromJSON('["OWNER", "MEMBER", "COLLABORATOR"]'), github.event.comment.author_association) | ||
| ) | ||
| timeout-minutes: 60 | ||
| runs-on: ubuntu-latest |
Collaborator
Author
There was a problem hiding this comment.
Could we add a new e2e environment to the github repo?
So that we can add environment: 'e2e' here --> would gate workflow runs on maintainer approval
Member
|
Hi Claire! I'm looking at the code rn but to answer one of your questions, I also cannot see environments or change organization roles. I think you'll need Rachel or maybe Kit to do that part! |
khanniie
approved these changes
Jul 5, 2026
| use: { ...devices['Desktop Chrome'] } | ||
| } | ||
|
|
||
| // { |
Member
There was a problem hiding this comment.
were these meant to be removed? why are they commented out?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
GSOC E2e Testing PR 1
.CodeMirrorcannot be found on CI --> unblocks Geeth to continue the projectDemo:
Screen.Recording.2026-07-04.at.17.07.29.mov
Changes:
develop, if author is @clairep94 or @Geethegreat -- temporary to enable faster development for GSOCcollaborator,maintainer, ormemberfor the repoNOTE:
@raclim @khanniie
environment: e2efor the E2e test workflow, so that the workflow run would be gated on maintainer approval, likedeploy-to-staging.I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123