fix: show preview for the last example in createCapture() docs#1427
fix: show preview for the last example in createCapture() docs#1427aashu2006 wants to merge 1 commit into
Conversation
|
sry for the delay @doradocodes , I've now fixed the last example as well, it only required to remove the
|
|
@aashu2006 I don't think this is the right file to make this fix, because examples are generated by a script with the content taken from the p5.js repo. So your current changes would get overridden the next time the script runs. @limzykenneth I have a question about this issue: currently @aashu2006 is trying to fix an issue in the |
|
@doradocodes Good catch. I can just add a regex replace in |
|
The reference examples are built from the inline reference of the source code on the p5.js repo and for the Removing the HTML in the example is only implemented for Depending on what the desired fix is, 1.x branches uses HTML tags and 2.x branches uses the To update the reference, they can be updated inline here but as @doradocodes mentioned, they will get replaced the next time there is a p5.js release, which means that in addition to making the inline change here, the relevant change should also be done in the relevant branch in the p5.js repo. |
|
@limzykenneth Thanks for the explanation! I think reworking the last example to use a standard canvas size (e.g. I can make the change in the |
|
@aashu2006 I don't think that would be an effective fix. Both the first example and the last example have layout problems when rendered, the first example doesn't have a canvas and the last example the canvas is not really doing anything. The problem from the layout stems from the element created by |

Fixes #1366
The preview for the last example on the
createCapture()reference page was missing. This happened because the example had a norender class assigned to it.This PR simply removes the
norenderclass from thecreateCapture.mdxfiles across all languages, which enables the live webcam preview to show up correctly on the website.