Skip to content

Fix: Remove extra 8px margin below Donate button in nav#1432

Open
SOUMITRO-SAHA wants to merge 2 commits into
processing:mainfrom
SOUMITRO-SAHA:fix/1423-remove-extra-margin-donate-button
Open

Fix: Remove extra 8px margin below Donate button in nav#1432
SOUMITRO-SAHA wants to merge 2 commits into
processing:mainfrom
SOUMITRO-SAHA:fix/1423-remove-extra-margin-donate-button

Conversation

@SOUMITRO-SAHA

Copy link
Copy Markdown

Closes #1423

Fix

  • MainNavLinks.tsx — Added styles.buttonsList CSS module class to the buttons <ul> for targeted styling.
  • styles.module.scss — Added .buttonsList rule inside .mainlinks that overrides margin-bottom: 0, removing only the trailing gap while preserving the spacing between the two lists.

Comment thread src/components/Nav/styles.module.scss Outdated
Comment on lines +52 to +55
.buttonsList {
margin-bottom: 0;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating a css class, you should use Tailwind classes in the element.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a simpler solution would be to remove the margin-bottom in /Nav/styles.module.css:

margin-bottom: var(--spacing-xs);
, since it's not necessary.

@doradocodes

Copy link
Copy Markdown
Contributor

@SOUMITRO-SAHA I left a comment for you! Please review. Thanks!

@SOUMITRO-SAHA

SOUMITRO-SAHA commented Jun 10, 2026

Copy link
Copy Markdown
Author
image

Addressed the review feedback — thank you @doradocodes!

Updated the fix per your suggestion: instead of adding a new CSS module class, I simply removed the margin-bottom: var(--spacing-xs) from the .mainlinks ul rule in styles.module.scss:49 since it's not necessary.

  • src/components/Nav/styles.module.scss: removed margin-bottom: var(--spacing-xs) from the ul rule
  • src/components/Nav/MainNavLinks.tsx: reverted back to plain Tailwind classes, no CSS module class needed

This is the simplest fix — removes the source of the extra 8px entirely. No new classes, no Tailwind overrides, no layout changes elsewhere.

I've tested locally and verified the spacing looks correct. Let me know if anything else needs tweaking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the 8px margin below the Start Coding and Donate buttons

2 participants