Skip to content

feat: add underline to links within text - #1528

Merged
limzykenneth merged 4 commits into
processing:mainfrom
coseeian:underline
Jul 27, 2026
Merged

feat: add underline to links within text#1528
limzykenneth merged 4 commits into
processing:mainfrom
coseeian:underline

Conversation

@coseeian

@coseeian coseeian commented Jul 22, 2026

Copy link
Copy Markdown
Collaborator

To address: #1505 .

Summary

  • styles/markdown.scss: add persistent text-decoration: underline to prose links inside .rendered-markdown, scoped as a:not(.button-link) so styled button links are excluded.

@limzykenneth

Copy link
Copy Markdown
Member

They are mostly there but there are some false negatives:

These probably should be underlined as well.
Screenshot 2026-07-22 at 12 00 28

These in community sketches too perhaps
Screenshot 2026-07-22 at 12 03 11

Should these be underlined too?
Screenshot 2026-07-22 at 12 04 04

I wonder if there is somewhere in the CSS rules that applies the p5 magenta highlight we can add the underline rule at the same place then we'll catch more or less the places we want to have underlines? Unless that introduce too many false positives.

@coseeian

Copy link
Copy Markdown
Collaborator Author

Let me take a look.

@coseeian

Copy link
Copy Markdown
Collaborator Author

Hi,

I found there wasn't one existing place to put it. The magenta link was being applied in 4 different ways across pages.

So I created .text-link in styles/global.scss. The single place now has one rule where the color and the underline are declared together.

.text-link works on a link itself or on any container (styling its descendant links). Every call site now points at that rule instead of redeclaring the color, and markdown.scss no longer duplicates the style.

Let me know if any concern about this approach, thanks. :)

@coseeian

coseeian commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

I verified both the Reference and Sketches pages locally, across light and dark modes - links now include underlines:

Screenshot 2026-07-27 at 18 54 54 Screenshot 2026-07-27 at 18 41 54

For the About page, axe-core only flags links inside body text, but I updated it as well for design consistency. Let me know if you prefer keeping it as-is!

Screenshot 2026-07-27 at 18 42 54

class="text-type-magenta"
href="https://openprocessing.org">OpenProcessing</a
>
<p class="text-xs md:text-base mb-3xl text-link">

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This updates the color to a slightly darker shade of magenta in light mode. I made this change to better align with the design across the rest of the site, but please let me know if you’d prefer to stick with the original shade. Thanks!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems fine to me!

Comment thread src/components/EducationResource/index.astro Outdated

@limzykenneth limzykenneth left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one inline. The rest looks good.

Comment thread src/components/EducationResource/index.astro Outdated
Co-authored-by: Kenneth Lim <hello@limzykenneth.com>

@ksen0 ksen0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! OK to merge I think

@limzykenneth
limzykenneth merged commit e9421de into processing:main Jul 27, 2026
7 checks passed
@coseeian
coseeian deleted the underline branch July 28, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants