feat: add underline to links within text - #1528
Conversation
|
Let me take a look. |
|
Hi, I found there wasn't one existing place to put it. The magenta link was being applied in 4 different ways across pages. So I created
Let me know if any concern about this approach, thanks. :) |
| class="text-type-magenta" | ||
| href="https://openprocessing.org">OpenProcessing</a | ||
| > | ||
| <p class="text-xs md:text-base mb-3xl text-link"> |
There was a problem hiding this comment.
Note: This updates the color to a slightly darker shade of magenta in light mode. I made this change to better align with the design across the rest of the site, but please let me know if you’d prefer to stick with the original shade. Thanks!
limzykenneth
left a comment
There was a problem hiding this comment.
Just one inline. The rest looks good.
Co-authored-by: Kenneth Lim <hello@limzykenneth.com>
ksen0
left a comment
There was a problem hiding this comment.
Thanks for this! OK to merge I think






To address: #1505 .
Summary
styles/markdown.scss: add persistenttext-decoration: underlineto prose links inside.rendered-markdown, scoped asa:not(.button-link)so styled button links are excluded.