fix: reinstate reference page filter with search by title and desc - #1532
Merged
Conversation
… tests
The reference filter matched keywords as raw substrings everywhere, so a
search for "sin" flooded results with common words containing it as a
substring ("using", "since", "single") and unrelated names ("asin").
Filtering now runs in two passes:
1. strict - exact function/section name matches + whole-word description
matches
2. loose - substring fallback, used only when the strict pass finds
nothing (so prefix searches like "typog" -> Typography and
"circ" -> circle still work)
When an exact or whole-word match exists, partial substrings are excluded,
exactly as requested in review. Keyword normalisation also strips trailing
punctuation so "sin." resolves to "sin".
The matching logic is extracted into pure, exported functions
(filterCategoryData, normalizeKeyword) and covered by unit tests for every
scenario raised in the PR discussion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1401
applies #1465 to
main