Skip to content

Add typography performance tests#8918

Open
shakeelmohamed wants to merge 4 commits into
processing:mainfrom
shakeelmohamed:bench-typography
Open

Add typography performance tests#8918
shakeelmohamed wants to merge 4 commits into
processing:mainfrom
shakeelmohamed:bench-typography

Conversation

@shakeelmohamed

@shakeelmohamed shakeelmohamed commented Jun 15, 2026

Copy link
Copy Markdown

Add initial performance benchmark tests and structure for typography tests.

PR Checklist

  • npm run lint passes
  • Document manual v1 to v2 test code via CLI
  • Create issues for remaining test cases

@ksen0 ksen0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work here! Comments below based on going through this PR with @limzykenneth .

The priority, especially if full completion is out of rant scope, is to complete the harness. If not possible to complete all the functions, these can be left open to community implementation in a new issue.

If possible, in addition to the minimal performance testing doc, it would be great to add instructions + example code for running manually (via CLI not the editor) a comparison between v1 and v2. As discussed, there is no equivalent quite for v1, but enabling comparison between v1 and v2 (even if manual / documentation primarily) would be ideall

Comment thread test/bench/REPORTS/WIP_REPORT_TYPOGRAPHY_TEST.md Outdated

Implementation notes:

- All pre-existing benchmarks included the full p5 instance setup which adds ~50ms to each test. The `textToPoints() single word, isolated benchmark` test is included as a potential way to isolate performance testing away from setup overhead.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: con be added to a new contributor doc on performance testing. That can be very short, so not necessary to add more than what you have here.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ksen0 added, please review!

Comment thread test/bench/typography.bench.js
Comment thread test/bench/typography.bench.js Outdated
Comment thread test/bench/typography.bench.js Outdated
@shakeelmohamed shakeelmohamed marked this pull request as ready for review June 29, 2026 07:12
@shakeelmohamed shakeelmohamed changed the title WIP: Add typography performance tests Add typography performance tests Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants