Skip to content

Fix framebuffer texture size clamping using wrong pixel density #8964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NalinDalal wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

Fix framebuffer texture size clamping using wrong pixel density #8964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/webgl/p5.Framebuffer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ class Framebuffer {
this.density = settings.density || this.renderer._pixelDensity;
if (settings.width && settings.height) {
const dimensions =
this.renderer._adjustDimensions(settings.width, settings.height);
this.renderer._adjustDimensions(settings.width, settings.height, this.density);
this.width = dimensions.adjustedWidth;
this.height = dimensions.adjustedHeight;
this._autoSized = false;
Expand Down Expand Up @@ -175,7 +175,7 @@ class Framebuffer {
resize(width, height) {
this._autoSized = false;
const dimensions =
this.renderer._adjustDimensions(width, height);
this.renderer._adjustDimensions(width, height, this.density);
width = dimensions.adjustedWidth;
height = dimensions.adjustedHeight;
this.width = width;
Expand Down
4 changes: 2 additions & 2 deletions src/webgl/p5.RendererGL.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,14 +441,14 @@ class RendererGL extends Renderer3D {
return gl.getParameter(gl.MAX_TEXTURE_SIZE);
}

_adjustDimensions(width, height) {
_adjustDimensions(width, height, density = this._pixelDensity) {
if (!this._maxTextureSize) {
this._maxTextureSize = this._getMaxTextureSize();
}
let maxTextureSize = this._maxTextureSize;

let maxAllowedPixelDimensions = Math.floor(
maxTextureSize / this._pixelDensity
maxTextureSize / density
);
let adjustedWidth = Math.min(width, maxAllowedPixelDimensions);
let adjustedHeight = Math.min(height, maxAllowedPixelDimensions);
Expand Down
Loading