fix: guard validateTwilioCredentials against null/non-object input#111
Merged
ralyodio merged 1 commit intoJun 27, 2026
Merged
Conversation
Calling validateTwilioCredentials(null) previously threw a TypeError because the function attempted to read properties before checking the input type. Added an early return for null/non-object inputs. Adds test cases for null, undefined, and string inputs. Fixes profullstack#107
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validateTwilioCredentials(null)previously threwTypeError: Cannot read properties of null (reading 'accountSid')because the function accessed object properties before checking the input typenull,undefined, and non-object inputsnull,undefined, and string inputsChanges
src/lib/utils/twilio-validator.js: added null/type guard at top ofvalidateTwilioCredentialstests/twilio-validator.test.js: added 3 new test cases for invalid input typesFixes #107