fix: URL extraction regex and code block placeholder collision (#105, #109)#112
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs reported in issues #105 and #109.
Fix #105 - Profile ID URL extraction rejects generated qryptchat IDs
File:
src/lib/utils/unique-identifier.jsThe regex expected exactly 10 alphanumeric characters, but generateShareableProfileUrl() produces identifiers like qryptchatA1B2C3D4 (17 chars). Changed regex to match the actual qryptchat prefix format.
Fix #109 - URL formatter code block placeholder collision
File:
src/lib/utils/url-link-converter.jsCode blocks were replaced with CODE_BLOCK_N placeholders. If a user typed that literal text, the restore step would incorrectly inject HTML. Changed delimiters to angle-bracket syntax that gets HTML-escaped in user text, making collision impossible.
Testing
Both fixes are targeted changes that preserve existing behavior for all valid inputs while fixing the specific edge cases described in the issues.
Closes #105, Closes #109