Set normalizeAnchor to true by default#61
Merged
AryaHassanli merged 3 commits intoApr 23, 2026
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request enables anchor normalization by default and updates the anchor label resolution logic in disco/references.go. It also introduces a nil check for the parent element in removeCrossReferenceStutter to prevent potential runtime errors. A review comment suggests simplifying the anchorLabel logic to eliminate redundant type assertions and improve code clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Alchemy baller to normalize anchors by default: