Skip to content

Set normalizeAnchor to true by default#61

Merged
AryaHassanli merged 3 commits into
project-chip:mainfrom
AryaHassanli:fix-normalize-anchor
Apr 23, 2026
Merged

Set normalizeAnchor to true by default#61
AryaHassanli merged 3 commits into
project-chip:mainfrom
AryaHassanli:fix-normalize-anchor

Conversation

@AryaHassanli
Copy link
Copy Markdown
Contributor

Update Alchemy baller to normalize anchors by default:

  • Set NormalizeAnchor to true by default
  • Fix a panic
  • If NormalizeAnchor is set, when discoballing references, the normalized anchor will be considered even for external files, without necessarily suggesting fix on them.

@AryaHassanli AryaHassanli requested a review from a team as a code owner April 13, 2026 18:42
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request enables anchor normalization by default and updates the anchor label resolution logic in disco/references.go. It also introduces a nil check for the parent element in removeCrossReferenceStutter to prevent potential runtime errors. A review comment suggests simplifying the anchorLabel logic to eliminate redundant type assertions and improve code clarity.

Comment thread disco/references.go
@AryaHassanli AryaHassanli merged commit 3b2a3a7 into project-chip:main Apr 23, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant