RHOAIENG-54719 fix list_local_queues KeyError on missing status#1058
Merged
openshift-merge-bot[bot] merged 1 commit intoMay 18, 2026
Merged
Conversation
rh-pre-commit.version: 2.3.2 rh-pre-commit.check-secrets: ENABLED
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1058 +/- ##
=======================================
Coverage 96.52% 96.52%
=======================================
Files 23 23
Lines 2271 2272 +1
=======================================
+ Hits 2192 2193 +1
Misses 79 79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kryanbeane
approved these changes
May 18, 2026
Contributor
kryanbeane
left a comment
There was a problem hiding this comment.
nice one David, lgtm👍🏻
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kryanbeane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
deca5d4
into
project-codeflare:main
20 of 38 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue link
https://redhat.atlassian.net/browse/RHOAIENG-54719
What changes have been made
list_local_queues() (kueue.py): stop indexing lq["status"] directly. Use lq_status = lq.get("status") or {} before checking flavors, so missing or null status does not raise KeyError, queues still appear (usually without a flavors key until Kueue reconciles).
Tests (test_kueue.py): test_list_local_queues_no_status covers no status, status: None, and normal flavor filtering.
Verification steps
Checks